adds route and helper to submit transaction to the horizon rpc #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
reviewed
Dec 14, 2023
| data, | ||
| error: null, | ||
| }; | ||
| } catch (e: any) { |
There was a problem hiding this comment.
I know you're just picking up this code from the Freighter codebase, but maybe we can type this error now. I think it should be BadResponseError from stellar-sdk
There was a problem hiding this comment.
oh yeah so I actually tried this but it turns out in TS, you can only annotate the error from the catch block as an any or unknown. https://byby.dev/ts-try-catch-error-type#:~:text=The%20only%20type%20annotations%20that,on%20it%20without%20type%20checking.
So I did annotate it in the response shape from this function but not sure if I can actually annotate the error as it come in from the catch block.
piyalbasu
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform team would like Freighter to start moving towards a world where it doesn't use the RPCs directly in an effort to move away from promoting the SDF hosted RPCs and to encourage community involvement.
This adds a way to submit transactions to the RPC through a route, submitting transactions to the Horizon RPC should work for Soroban(invoke host fn) ops as well.