adds prom client and initial set of metrics #15
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is debug access?Uses debug, reflection and dynamic code execution features. Removing the use of debug will reduce the risk of any reflection and dynamic code execution. What is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| instance.route({ | ||
| method: "GET", | ||
| url: "/metrics", | ||
| handler: async (_request, reply) => { | ||
| reply.header("Content-Type", register.contentType); | ||
| register.metrics().then((data) => reply.code(200).send(data)); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
It's 8080 right now
There was a problem hiding this comment.
I this separate from the main application port? If you use the same port it means that metrics might get exposed on the internet.
It's often useful expose metrics on a separate port
There was a problem hiding this comment.
oh yeah good point, it is on the same port as the app so I'll update that to a metrics specific port. Thank you!
Adds the prometheus client and initial set of metrics in order to setup metrics through k8s and Prometheus.