[REFACTOR] Changes to simulate-tx route
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imulate endpoint, renames parameter to be more clear, adds test for simulate-tx route
|
Preview is available here: |
piyalbasu
approved these changes
Nov 21, 2024
aristidesstaffieri
deleted the
bug/rename-misleading-param-simulate-tx
branch
Merged
aristidesstaffieri
added a commit
that referenced
this pull request
Dec 11, 2024
* makes the simulate-tx endpoint follow response conventions of other simulate endpoint, renames parameter to be more clear, adds test for simulate-tx route (#183) * Bump the minor-and-patch group with 10 updates (#187) Bumps the minor-and-patch group with 10 updates: | Package | From | To | | --- | --- | --- | | [@blockaid/client](https://github.com/blockaid-official/blockaid-client-node) | `0.29.1` | `0.31.0` | | [@fastify/rate-limit](https://github.com/fastify/fastify-rate-limit) | `10.1.1` | `10.2.1` | | [@sentry/node](https://github.com/getsentry/sentry-javascript) | `8.38.0` | `8.42.0` | | [axios](https://github.com/axios/axios) | `1.7.7` | `1.7.9` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.9.0` | `22.10.1` | | [dotenv](https://github.com/motdotla/dotenv) | `16.4.5` | `16.4.7` | | [husky](https://github.com/typicode/husky) | `9.1.6` | `9.1.7` | | [prettier](https://github.com/prettier/prettier) | `3.3.3` | `3.4.2` | | [typescript](https://github.com/microsoft/TypeScript) | `5.6.3` | `5.7.2` | | [webpack](https://github.com/webpack/webpack) | `5.96.1` | `5.97.1` | Updates `@blockaid/client` from 0.29.1 to 0.31.0 - [Release notes](https://github.com/blockaid-official/blockaid-client-node/releases) - [Changelog](https://github.com/blockaid-official/blockaid-client-node/blob/main/CHANGELOG.md) - [Commits](blockaid-official/blockaid-client-node@v0.29.1...v0.31.0) Updates `@fastify/rate-limit` from 10.1.1 to 10.2.1 - [Release notes](https://github.com/fastify/fastify-rate-limit/releases) - [Commits](fastify/fastify-rate-limit@v10.1.1...v10.2.1) Updates `@sentry/node` from 8.38.0 to 8.42.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@8.38.0...8.42.0) Updates `axios` from 1.7.7 to 1.7.9 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.7...v1.7.9) Updates `@types/node` from 22.9.0 to 22.10.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `dotenv` from 16.4.5 to 16.4.7 - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.4.5...v16.4.7) Updates `husky` from 9.1.6 to 9.1.7 - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v9.1.6...v9.1.7) Updates `prettier` from 3.3.3 to 3.4.2 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.3...3.4.2) Updates `typescript` from 5.6.3 to 5.7.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.6.3...v5.7.2) Updates `webpack` from 5.96.1 to 5.97.1 - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.96.1...v5.97.1) --- updated-dependencies: - dependency-name: "@blockaid/client" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@fastify/rate-limit" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@sentry/node" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: axios dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: dotenv dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates
simulate-txfor the following -Follows same response format as
simulate-token-transferRenames
signed_xdrparam to justxdras this is before signatureAdds test for the route
Why
In support of issue #1459
This route is unused by Freighter client today and has gone stale. I revived it in order to move the Soroswap simulation to it on non custom networks.