tweaks the response for invoke host fns to expose fn name and args #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heytdep
reviewed
Jan 17, 2024
| const hostFn = xdr.HostFunction.fromXDR( | ||
| Buffer.from(edge.node.hostFunction, "base64") | ||
| ); | ||
| const invocation = hostFn.invokeContract(); |
There was a problem hiding this comment.
Not sure what your requirements are in terms of operations you display, but it's worth pointing out that host invocations can also be create contract and uploadcontractwasm.
There was a problem hiding this comment.
hey thanks for the info there, the client ignores those types for now but we may pull those into history in the future as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the history response for a Mercury change, pulling the fn args/name from the HostFunction instead of expecting an tx_envelope.
Tweaks the metrics reporter for Horizon calls to avoid alerting on NotFound errors.