[FEAT] adds call and route to index token account balance #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
reviewed
Oct 26, 2023
| url: "/account-balances/:pub-key", | ||
| schema: { | ||
| params: { | ||
| ["pub-key"]: { type: "string" }, |
There was a problem hiding this comment.
no need to make this optimization now, but might be useful to think about if we want to store things like params and query string values in an enum as we introduce more routes/complexity
piyalbasu
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new Mercury service calls to build a token balance key, and to subscribe to token balances.
New Route:
GET
/account-balances/:pub-keyPOST
/subscription/token-balanceAdds customer validator to check that arguments can resolve to contract addresses,
isContractId.Todo:
Mercury is currently working on adding classic asset balances to full account subscriptions, once that feature is live then we can add the query to fetch balances to
MercuryService.getAccountBalances