Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain token payment by auth entries #31

Merged
merged 7 commits into from
Feb 8, 2024
7 changes: 7 additions & 0 deletions src/helper/error.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export const ERROR = {
ACCOUNT_NOT_SOURCE:
"Transfer contains authorization entry for a different account",
FOREIGN_CONTRACT_AUTH:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we mean to use this error in this pull request or are you planning to use it in a follow-up change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'll remove that one, @sisuresh pointed how that check was already covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in 3272c3c

"Transfer contains authorization entry for another contract",
SUB_INVOCATIONS: "Transfer contains sub-invocations to another contract",
};
2 changes: 1 addition & 1 deletion src/helper/horizon-rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export const submitTransaction = async (
error: null,
};
} catch (e: any) {
if (e.response.status === 504) {
if (e.response?.status === 504) {
// in case of 504, keep retrying this tx until submission succeeds or we get a different error
// https://developers.stellar.org/api/errors/http-status-codes/horizon-specific/timeout
// https://developers.stellar.org/docs/encyclopedia/error-handling
Expand Down
26 changes: 24 additions & 2 deletions src/route/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ import {
Transaction,
TransactionBuilder,
XdrLargeInt,
xdr,
} from "stellar-sdk";
import { buildTransfer, simulateTx } from "../helper/soroban-rpc";
import { ERROR } from "../helper/error";

const API_VERSION = "v1";

Expand Down Expand Up @@ -545,17 +547,37 @@ export async function initApiServer(
const simulationResponse = (await server.simulateTransaction(
tx
)) as SorobanRpc.Api.SimulateTransactionSuccessResponse;

const preparedTransaction = SorobanRpc.assembleTransaction(
tx,
simulationResponse
);

const built = preparedTransaction.build();
const sorobanOp = built
.operations[0] as Operation.InvokeHostFunction;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we inspect all operations or is only looking at the first one always sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of a tx with an InvokeHostFunction, there can only be 1 operation. We could check for the operation type here but only the InvokeHostFunction type has auth. I'll add an explicit check for the op type though, that seems a bit more clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an explicit check for op type in 3272c3c

const auths = sorobanOp.auth || [];

for (const auth of auths) {
if (
auth.credentials().switch() !==
xdr.SorobanCredentialsType.sorobanCredentialsSourceAccount()
) {
throw new Error(ERROR.ACCOUNT_NOT_SOURCE);
}

if (auth.rootInvocation().subInvocations().length) {
throw new Error(ERROR.SUB_INVOCATIONS);
}
}

const data = {
simulationResponse,
preparedTransaction: preparedTransaction.build().toXDR(),
preparedTransaction: built.toXDR(),
};
reply.code(200).send(data);
} catch (error) {
reply.code(400).send(JSON.stringify(error));
reply.code(400).send(error);
}
},
});
Expand Down
Loading