-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding blockaid byline and feedback form #1767
Open
piyalbasu
wants to merge
12
commits into
master
Choose a base branch
from
feature/blockaid-reporting-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add API stubbing for addAsset and test gh action * fix yml ternary * try empty string for ternary * fix stubbing for stellar.expert API * all multiple workers when not in INTEGRATION MODE * don't allow multiple workers until all calls are stubbed * adding central location for stubs
* add v3 and v4 response types for signMessage, return v4 response according to package version * Added translations * moves version toggle for signMessage to the background script
* show user XDR string when sending/swapping * Added translations * fix duplicate test-id * fix type issue with memo
Bumps [@stellar/design-system](https://github.com/stellar/stellar-design-system) from 2.0.0-beta.15 to 2.0.0-beta.17. - [Release notes](https://github.com/stellar/stellar-design-system/releases) - [Commits](https://github.com/stellar/stellar-design-system/commits) --- updated-dependencies: - dependency-name: "@stellar/design-system" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@stellar/design-system](https://github.com/stellar/stellar-design-system) from 2.0.0-beta.15 to 2.0.0-beta.17. - [Release notes](https://github.com/stellar/stellar-design-system/releases) - [Commits](https://github.com/stellar/stellar-design-system/commits) --- updated-dependencies: - dependency-name: "@stellar/design-system" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the all-actions group with 2 updates in the / directory: [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) and [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `rtCamp/action-slack-notify` from 2.3.0 to 2.3.2 - [Release notes](https://github.com/rtcamp/action-slack-notify/releases) - [Commits](rtCamp/action-slack-notify@v2.3.0...c337377) Updates `ruby/setup-ruby` from 1.203.0 to 1.204.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@v1.203.0...v1.204.0) --- updated-dependencies: - dependency-name: rtCamp/action-slack-notify dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [nanoid](https://github.com/ai/nanoid). Updates `nanoid` from 3.3.7 to 3.3.8 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aristidesstaffieri
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695 and #1592
Powered by Blockaid
byline to all the modalsFor asset warning feedback, the user just sends some details about what they think is wrong
For tx warning feedback, they can select whether there's an improper "malicious" flag or if the simulation result is wrong
Screen.Recording.2025-01-07.at.1.30.01.PM.mov
Screen.Recording.2025-01-07.at.1.34.22.PM.mov