allow for handling of redirects in toml resolver #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Sep 23, 2024
Shaptic
approved these changes
Sep 24, 2024
|
Ah yes, @KyleSmith19091 you need to gpg sign your commits for them to be merged into this repo 🙏 |
KyleSmith19091
force-pushed
the
redirect-toml-resolver
branch
2 times, most recently
from
8217e25 to
f714a5b
Compare
Signed-off-by: KyleSmith19091 <[email protected]>
Signed-off-by: KyleSmith19091 <[email protected]>
Signed-off-by: KyleSmith19091 <[email protected]>
Signed-off-by: KyleSmith19091 <[email protected]>
Signed-off-by: KyleSmith19091 <[email protected]>
Signed-off-by: KyleSmith19091 <[email protected]>
KyleSmith19091
force-pushed
the
redirect-toml-resolver
branch
from
f714a5b to
8963883
Compare
|
@Shaptic would you mind just taking a look again, I merged master and noticed the change from using axios to instead using the httpClient interface, so just had to make a small change |
Shaptic
approved these changes
Sep 27, 2024
BlaineHeffron
pushed a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Nov 13, 2024
* allow for handling of redirects * correct unit tests for resolver * add maxRedirects to http client request config --------- Signed-off-by: KyleSmith19091 <[email protected]> Co-authored-by: George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: #1052