-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stable Protocol 20 release (both XDR and RPC schemas) #886
Conversation
Size Change: -329 kB (-3%) Total Size: 11.7 MB
|
@@ -146,7 +146,7 @@ | |||
"bignumber.js": "^9.1.2", | |||
"eventsource": "^2.0.2", | |||
"randombytes": "^2.1.0", | |||
"stellar-base": "10.0.0-beta.4", | |||
"stellar-base": "git+https://github.com/stellar/js-stellar-base#master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this pr wait on stellar-base to release first, and pin this to 10.0.0
here, or you anticipate doing another release prep pr with that bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge because this won't be released, and then have a separate PR to update to the stable git ref and bump to the stable version. This will make it easier to isolate the changes that need to be reviewed! And we can use master
as the gitref for E2E tests. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that works, could also git ref to the pr for e2e concerns, so whichever process is preferred, I just was curious on the pinning aspect there, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one comment on the stellar-base ref.
This prepares a stable Protocol 20 release with support for the latest XDR and RPC schemas, including:
@stellar/
organization #887This should mirror stellar/js-soroban-client#167.
For reviewers: The best way to review this, imo, is to compare it directly to the changes that were made in
soroban-client
to the stable branch. Specifically, this diff covers everything needed for the latest stable version.