Native token contract wrapper interface #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to resolve conflicts and merge this. We can figure out how to test it after. |
More recently we've started to chew time on things that weren't tested in the host. I think there would be some value in verifying this works with some basic tests, especially if we are suspicious it doesn't work. |
|
I'm not saying we shouldn't test it. I'm saying I want to merge this so it doesn't get stale again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #316, stellar-deprecated/soroban-token-contract#5, and stellar/soroban-examples#119
Why
Interoperability with classic.
Known limitations
No tests yet so it might not actually work