Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK support for Address<->strkey conversions. #1112

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Oct 9, 2023

What

Add SDK support for Address<->strkey conversions.

Why

Supporting the respective env changes.

Known limitations

N/A

github-merge-queue bot pushed a commit to stellar/rs-soroban-env that referenced this pull request Oct 9, 2023
### What

Use Address for `call_account_contract_check_auth` test helper.

### Why

This is one of the functions that has been overlooked during
Bytes->Address migration. This is also needed to support
stellar/rs-soroban-sdk#1112

### Known limitations

N/A
soroban-sdk/src/address.rs Show resolved Hide resolved
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple requests about the API.

soroban-sdk/src/address.rs Outdated Show resolved Hide resolved
soroban-sdk/src/address.rs Outdated Show resolved Hide resolved
soroban-sdk/src/address.rs Outdated Show resolved Hide resolved
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple requests about the API.

@dmkozh dmkozh enabled auto-merge October 10, 2023 18:52
@dmkozh dmkozh disabled auto-merge October 10, 2023 18:52
@dmkozh dmkozh enabled auto-merge October 10, 2023 18:55
soroban-sdk/src/address.rs Show resolved Hide resolved
@dmkozh dmkozh added this pull request to the merge queue Oct 10, 2023
Merged via the queue into stellar:main with commit 64826c8 Oct 10, 2023
@dmkozh dmkozh deleted the address_fn branch October 10, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants