Generate all types of addresses when fuzzing. #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
I wonder, there could be cases where someone specifically wants arbitrary contract addresses, but I think they can probably produce that themselves using the Address::random fn that just happens to only provide C addresses.
It's important the arbitrary on Address does both because contracts need to be able to handle both and this could be a good thing to catch.
brson
added a commit
to brson/rs-soroban-sdk
that referenced
this pull request
Mar 4, 2024
This reverts commit 6b04bfc.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
This reverts commit 6b04bfc. Closes #1221 ### What In #1122, I changed the impl of `Arbitrary` for `Address` to generate all types of addresses instead of only contract addresses. I no longer think that was the correct thing to do, so this changes the impl back to only generate contract addresses. ### Why Described in the issue #1221 In short, native addresses are difficult to test with, particularly in conjunction with the native token contract, because they require set up of storage and trustlines. Doing this setup is possible, but is not obvious, and users running into such errors during testing are likely to get stuck. ### Known limitations This is arguably a breaking change, though only to the testing environment, and only to fuzzers. I think it is likely there are so few fuzzing users that nobody will notice; better to do it sooner than later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generate both ScAddress::Contract and ScAddress::Account when fuzzing.
Why
Currently only ScAddress::Contract is generated.
Closes #1096
Known limitations
I don't really understand the consequences for fuzz testers of making this change. Maybe there aren't any. I have tested that the fuzzer in soroban-examples continues to work.