feat: Add new Key type; allowing public keys to be named keys
#1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
feat/muxed_keys
branch
from
cca279c to
10fb1da
Compare
This will allow users to add public keys with `keys add` so that they can be referenced in commands that need public addresses and contract invoke's that take address arguments.
Add tests using
willemneal
force-pushed
the
feat/muxed_keys
branch
2 times, most recently
from
09d72f1 to
31cde54
Compare
Co-authored-by: Leigh McCulloch <[email protected]>
willemneal
force-pushed
the
feat/muxed_keys
branch
from
102bc13 to
b36db49
Compare
cmd/soroban-cli/src/config/secret.rs
Outdated
| } | ||
|
|
||
| impl Args { | ||
| pub fn read_secret(&self) -> Result<Secret, Error> { | ||
| pub fn read_key(&self) -> Result<Key, key::Error> { |
There was a problem hiding this comment.
I wonder if this could go in config/key.rs instead, since it is also dealing with public keys
There was a problem hiding this comment.
Here it is just for parsing the Arg struct. So it only should be used with the keys add command. Though then maybe it should just go into that command? Since there is no reuse of this function.
There was a problem hiding this comment.
I kind of like the idea of moving it to the add command, since that is where it's being used. But not merge blocking!
Co-authored-by: Elizabeth Engelman <[email protected]>
Co-authored-by: Elizabeth Engelman <[email protected]>
Co-authored-by: Willem Wyndham <[email protected]>
This simplifies the lookup of the address.
This will allow for exporting the phrase later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to add public keys with
keys addso that they can be referenced in commands that need public addresses and contract invoke's that take address arguments.This is part 1 of 2 in a stack made with GitButler:
Keytype; allowing public keys to be named keys #1700 👈