Hot archive tx apply #4603
Merged
Hot archive tx apply #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
hot-archive-tx-apply
branch
3 times, most recently
from
7a04b44 to
ff852cc
Compare
SirTyson
force-pushed
the
hot-archive-tx-apply
branch
3 times, most recently
from
8b133db to
c42168a
Compare
dmkozh
reviewed
Jan 10, 2025
dmkozh
previously approved these changes
Jan 14, 2025
SirTyson
force-pushed
the
hot-archive-tx-apply
branch
2 times, most recently
from
bc92eb4 to
0341ff5
Compare
dmkozh
reviewed
Jan 14, 2025
SirTyson
force-pushed
the
hot-archive-tx-apply
branch
from
0341ff5 to
c7e470a
Compare
Done |
dmkozh
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4584
This PR adds support for the Hot Archive to TX apply. Specifically,
InvokeHostFunctionOpwill check both the live BucketList and Hot Archive BucketList for archived entries. TheRestoreFootprintOpcan now restore entries from both the live BucketList and Hot Archive.Additionally, restore meta has also changed for p23. The
LEDGER_ENTRY_RESTOREDtype has been added for the restore op. When an entry is restored. both theLedgerEntryof the restored data and the correspondingTTLentry are emitted asLEDGER_ENTRY_RESTORED LedgerEntryChangeType. If the entry has not yet been evicted (such that the entry and it's TTL still exist in the live BucketList), the preexisting TTL value will be emitted asLEDGER_ENTRY_STATE. If the entry has been evicted such that the TTL value has been previously deleted, only a single change type ofLEDGER_ENTRY_RESTOREDwill be emitted for the new value. For the data being restored,LEDGER_ENTRY_STATEis never emitted.Rebased on #4585.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)