Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor assets to simplify Wallet Setup #108

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

marwen-abid
Copy link
Collaborator

What

Refactoring setup_assets_for_network_service to simplify wallet setup.

Why

Currently wallets have to input assets manually when adding an entry. We want to simplify that.

Known limitations

[TODO or N/A]

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid requested a review from a team November 24, 2023 19:28
@marwen-abid marwen-abid self-assigned this Nov 24, 2023
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 24, 2023 19:28 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests November 24, 2023 19:28 — with GitHub Actions Inactive
Copy link
Contributor

@ceciliaromao ceciliaromao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 👌

@marwen-abid marwen-abid merged commit f53b45a into develop Nov 24, 2023
6 checks passed
@marwen-abid marwen-abid deleted the chore/refactor-assets-for-wallet-setup branch November 24, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants