Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-960] serve/httphandler: API endpoint to fetch the verification types #113

Merged
merged 6 commits into from
Nov 28, 2023
Merged

[SDP-960] serve/httphandler: API endpoint to fetch the verification types #113

merged 6 commits into from
Nov 28, 2023

Conversation

ceciliaromao
Copy link
Contributor

What

API endpoint to get the verification types
GET receiver/verification-types

Why

Add dropdown for choosing Verification Type when creating new disbursements on FE

Known limitations

N/A

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 16:58 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 16:58 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao self-assigned this Nov 28, 2023
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 16:59 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 16:59 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 17:00 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 17:01 — with GitHub Actions Inactive
CaioTeixeira95
CaioTeixeira95 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Feel free to merge after addressing the PR comments.

internal/serve/httphandler/receiver_handler_test.go Outdated Show resolved Hide resolved
internal/serve/httphandler/receiver_handler_test.go Outdated Show resolved Hide resolved
internal/serve/httphandler/receiver_handler_test.go Outdated Show resolved Hide resolved
internal/serve/httphandler/receiver_handler.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 17:43 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 17:43 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 17:47 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 17:47 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr113.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr113.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr113.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao merged commit b279c36 into develop Nov 28, 2023
6 checks passed
@ceciliaromao ceciliaromao deleted the SDP-960_api-endpoint_get-verification-types branch November 28, 2023 17:53
@ceciliaromao ceciliaromao mentioned this pull request Feb 12, 2024
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaioTeixeira95 CaioTeixeira95 CaioTeixeira95 approved these changes

@marcelosalloum marcelosalloum Awaiting requested review from marcelosalloum

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

@ziyliu ziyliu Awaiting requested review from ziyliu

Assignees

@ceciliaromao ceciliaromao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceciliaromao @stellar-jenkins @CaioTeixeira95