docker-compose.yml refactor #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to remove depends_on entries from services in order to install. This error typically occurs when a service defined in a Docker Compose file attempts to extend another service that has depends_on attributes. According to Docker Compose's documentation, a service that uses depends_on cannot be extended.
Removed depends_on references. This error typically occurs when a service defined in a Docker Compose file attempts to extend another service that has depends_on attributes. According to Docker Compose's documentation, a service that uses depends_on cannot be extended
Removed depends_on references This error typically occurs when a service defined in a Docker Compose file attempts to extend another service that has depends_on attributes. According to Docker Compose's documentation, a service that uses depends_on cannot be extended
Moves depends_on to main docker.compose.
Moves depends_on to main docker.compose.
Moves depends_on to main docker.compose.
Moves 'depends_on' sections from service definitions to top-level docker-compose.yml https://docs.docker.com/compose/compose-file/05-services/#restrictions
steven-tomlinson
changed the title
marwen-abid
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Thank you for this contribution @steven-tomlinson! There is just one small typo to fix then we can get this merged in the repo.
Corrects typo in version number.
steven-tomlinson
commented
Dec 5, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
steven-tomlinson
had a problem deploying
to
Anchor Integration Tests
GitHub Actions
Failure
steven-tomlinson
had a problem deploying
to
Receiver Registration - E2E Integration Tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor docker-compose to move 'depends_on' settings to top-level docker-compose.yml
Why
Extended services may not use depends_on.
https://docs.docker.com/compose/compose-file/05-services/#restrictions
Known limitations
N/A
Checklist
PR Structure
Thoroughness
Configs and Secrets
values.yamlfile.pr-preview,dev,demo,prd).values.yamlfile.pr-preview secrets,dev secrets,demo secrets,prd secrets).Release
developormainafter it's ready for production!Deployment