Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP use patched ap for sdp-001 #115

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

reecexlm
Copy link
Collaborator

@reecexlm reecexlm commented Dec 4, 2023

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@reecexlm reecexlm temporarily deployed to Anchor Integration Tests December 4, 2023 19:04 — with GitHub Actions Inactive
@reecexlm reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests December 4, 2023 19:04 — with GitHub Actions Inactive
@reecexlm reecexlm marked this pull request as draft December 4, 2023 19:04
@reecexlm reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests December 4, 2023 21:48 — with GitHub Actions Inactive
@reecexlm reecexlm temporarily deployed to Anchor Integration Tests December 4, 2023 21:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants