Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/improve error logs for debugging #125

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Hotfix/improve error logs for debugging #125

merged 3 commits into from
Dec 13, 2023

Conversation

marcelosalloum
Copy link
Collaborator

@marcelosalloum marcelosalloum commented Dec 13, 2023 •
edited
Loading

What

Add the client_domain when logging the message where the user with the {phone_number, client_domain} pair could not be found.

Also, updated a log from error to warn.

Why

Better debuggability.

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marcelosalloum marcelosalloum self-assigned this Dec 13, 2023
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests December 13, 2023 22:10 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests December 13, 2023 22:10 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr125.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr125.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr125.previews.kube001.services.stellar-ops.com

marwen-abid
marwen-abid approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests December 13, 2023 22:16 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests December 13, 2023 22:16 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests December 13, 2023 22:16 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests December 13, 2023 22:16 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr125.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr125.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr125.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum merged commit d208a08 into main Dec 13, 2023
13 checks passed
@marcelosalloum marcelosalloum deleted the hotfix/improve-error-logs-for-debugging branch December 13, 2023 22:46
@marcelosalloum marcelosalloum mentioned this pull request Dec 15, 2023
Merged
marcelosalloum added a commit that referenced this pull request Dec 16, 2023
@marcelosalloum
Release 1.0.1 to develop (#129)
c26c2f5 
### What

[Release 1.0.1](#127) to develop

### Why

To sync the `main` branch hotfixes:
- #125 
- #126
ziyliu added a commit that referenced this pull request Dec 21, 2023
@ziyliu
[SDP-962] Change SEP-24 Flow to display different verifications based…
5a7e1cd 
… on Disbursement's verification type (#116)

Modify the SEP-24 flow to perform verification for an entered phone number based on the latest verification type.

The current SEP-24 flow is hardcoded to only accept date of birth but we will have disbursement files that will include pin and national id, and the front-end will need to change to be able to parse those values.

Release 1.0.1 to develop (#129)

[Release 1.0.1](#127) to develop

To sync the `main` branch hotfixes:
- #125
- #126

changes:

fix tests

migrate
ziyliu added a commit that referenced this pull request Dec 21, 2023
@ziyliu
[SDP-962] Change SEP-24 Flow to display different verifications based…
dbba8d4 
… on Disbursement's verification type (#116)

Modify the SEP-24 flow to perform verification for an entered phone number based on the latest verification type.

The current SEP-24 flow is hardcoded to only accept date of birth but we will have disbursement files that will include pin and national id, and the front-end will need to change to be able to parse those values.

Release 1.0.1 to develop (#129)

[Release 1.0.1](#127) to develop

To sync the `main` branch hotfixes:
- #125
- #126

changes:

fix tests

migrate
marwen-abid pushed a commit that referenced this pull request Dec 22, 2023
@ziyliu @marwen-abid
[SDP-962] Change SEP-24 Flow to display different verifications based…
90c441b 
… on Disbursement's verification type (#116)

Modify the SEP-24 flow to perform verification for an entered phone number based on the latest verification type.

The current SEP-24 flow is hardcoded to only accept date of birth but we will have disbursement files that will include pin and national id, and the front-end will need to change to be able to parse those values.

Release 1.0.1 to develop (#129)

[Release 1.0.1](#127) to develop

To sync the `main` branch hotfixes:
- #125
- #126

changes:

fix tests

migrate
ziyliu pushed a commit that referenced this pull request Feb 1, 2024
@marcelosalloum @marwen-abid
Sync main into develop (#169)
43644d6 
* Hotfix/improve error logs for debugging (#125)

### What

Add the client_domain when logging the message where the user with the {phone_number, client_domain} pair could not be found.

Also, updated a log from error to warn.

### Why

Better debuggability.

* [SDP-1022] Hotfix: update Vibrant Assist's `client_domain` (#126)

### What

Update client_domain on Vibrant Assist from api.vibrantapp.com to vibrantapp.com.

### Why

It was incorrect.

---------

Co-authored-by: Marwen Abid <[email protected]>
@marwen-abid marwen-abid mentioned this pull request Feb 10, 2024
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwen-abid marwen-abid marwen-abid approved these changes

Assignees

@marcelosalloum marcelosalloum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelosalloum @stellar-jenkins @marwen-abid