Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-1269] Add CI to validate single-tenant to multi-tenant migration #356

Merged
merged 9 commits into from
Jul 23, 2024
Merged

[SDP-1269] Add CI to validate single-tenant to multi-tenant migration #356

merged 9 commits into from
Jul 23, 2024

Conversation

marcelosalloum
Copy link
Collaborator

@marcelosalloum marcelosalloum commented Jul 18, 2024 •
edited
Loading

What

Add a CI workflow to validate single-tenant to multi-tenant migration

Why

To make sure the migration still works and that our instructions are accurate.

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marcelosalloum marcelosalloum self-assigned this Jul 18, 2024
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum force-pushed the marcelo/SDP-1269-CI-singletenant-to-multitenant-check branch from ededc60 to 5edf26e Compare July 18, 2024 23:00
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum force-pushed the marcelo/SDP-1269-CI-singletenant-to-multitenant-check branch from 5edf26e to f7d345f Compare July 18, 2024 23:04
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum force-pushed the marcelo/SDP-1269-CI-singletenant-to-multitenant-check branch from f7d345f to 673bf09 Compare July 19, 2024 23:07
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 19, 2024 23:07 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum changed the base branch from develop to marcelo/chore-refactor-integration-scripts July 19, 2024 23:11
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 19, 2024 23:19 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests July 19, 2024 23:32 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 19, 2024 23:32 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 19, 2024 23:32 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) July 19, 2024 23:32 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum requested a review from a team July 19, 2024 23:59
@marcelosalloum marcelosalloum marked this pull request as ready for review July 19, 2024 23:59
marwen-abid
marwen-abid approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great

.github/workflows/singletenant_to_multitenant_db_migration_test.yml

- name: Run Migration
run: |
docker exec e2e-sdp-v2-database bash -c "psql -d $DATABASE_URL -c \"SELECT admin.migrate_tenant_data_from_v1_to_v2('migrated-tenant');\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from marcelo/chore-refactor-integration-scripts to develop July 23, 2024 00:49
@marcelosalloum marcelosalloum force-pushed the marcelo/SDP-1269-CI-singletenant-to-multitenant-check branch from 67f95fd to 799c7a8 Compare July 23, 2024 00:52
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests July 23, 2024 00:52 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 23, 2024 00:52 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) July 23, 2024 00:52 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) July 23, 2024 00:52 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr356.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr356.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr356.previews.kube001.services.stellar-ops.com

@marcelosalloum marcelosalloum merged commit ca4aa72 into develop Jul 23, 2024
15 checks passed
@marcelosalloum marcelosalloum deleted the marcelo/SDP-1269-CI-singletenant-to-multitenant-check branch July 23, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwen-abid marwen-abid marwen-abid approved these changes

Assignees

@marcelosalloum marcelosalloum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelosalloum @stellar-jenkins @marwen-abid