Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1259] Export Disbursements with Filters #490

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

marwen-abid
Copy link
Collaborator

@marwen-abid marwen-abid commented Dec 9, 2024

What

  • Add a new endpoint GET /exports/disbursements

Returned CSV :

ID,Name,Wallet.Name,Asset.Code,Asset.Issuer,Status,VerificationField,CreatedAt,UpdatedAt,RegistrationContactType,TotalPayments,SuccessfulPayments,FailedPayments,CanceledPayments,RemainingPayments,AmountDisbursed,TotalAmount,AverageAmount
68494ca8-4f49-4d56-af81-42589963293c,WA_XLM,User Managed Wallet,XLM,,COMPLETED,,2024-11-28T22:31:24.722812Z,2024-11-28T22:31:36.441927Z,EMAIL_AND_WALLET_ADDRESS,1,1,0,0,0,0.12,0.12,0.12
9427421d-9540-4942-85c0-a2de2a45de31,WA_XLM_@,User Managed Wallet,XLM,,COMPLETED,,2024-11-28T22:34:44.172295Z,2024-11-28T22:34:52.497641Z,EMAIL_AND_WALLET_ADDRESS,1,1,0,0,0,0.12,0.12,0.12

Why

  • Add ability to export disbursements in CSV

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid self-assigned this Dec 9, 2024
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests December 9, 2024 19:53 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) December 9, 2024 19:53 — with GitHub Actions Inactive
@marwen-abid marwen-abid force-pushed the feat/SDP-1259-export-disbursements branch from 0cf648b to 671558f Compare December 9, 2024 22:16
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) December 9, 2024 22:16 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests December 9, 2024 22:16 — with GitHub Actions Inactive
@marwen-abid marwen-abid force-pushed the feat/SDP-1259-export-disbursements branch from 671558f to 4e1ec1c Compare December 9, 2024 22:22
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) December 9, 2024 22:22 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests December 9, 2024 22:22 — with GitHub Actions Inactive
@marwen-abid marwen-abid force-pushed the feat/SDP-1259-export-disbursements branch from 4e1ec1c to 2a7b4d1 Compare December 9, 2024 22:22
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests December 9, 2024 22:23 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) December 9, 2024 22:23 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests December 9, 2024 22:41 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) December 9, 2024 22:41 — with GitHub Actions Inactive
@marwen-abid marwen-abid changed the title [SDP-1259] Export Disbursements [SDP-1259] Export Disbursements with Filters Dec 9, 2024
Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marwen-abid marwen-abid merged commit bf242be into develop Dec 10, 2024
13 checks passed
@marwen-abid marwen-abid deleted the feat/SDP-1259-export-disbursements branch December 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants