Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into sdp-multitenant #88

Closed
wants to merge 5 commits into from

Conversation

marwen-abid
Copy link
Collaborator

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

ceciliaromao and others added 4 commits October 30, 2023 11:41
…ertain time period (#78)

What
Automatic cancellation of pending payments after a certain time period

Why
If a payment has been in 'ready' status for more than a certain quantity of days, move from 'ready' to 'canceled' status. Do not pay the receiver if they verify their identity after that.
What
Include CANCELED payment status to statistics

Why
Sentry alerts: status CANCELED is not a valid payment status
### What

Truncate error messages before patching transactions on the anchor platform.

### Why

We were sending an error message with more than 255 characters which causes an error on the Anchor Platform.

Closes #70
…ics (#82)

What
Get canceled payments for disbursement and receiver metrics

Why
statistics metrics on FE
@marwen-abid marwen-abid self-assigned this Nov 8, 2023
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests November 8, 2023 23:29 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests November 8, 2023 23:29 — with GitHub Actions Inactive
@marwen-abid marwen-abid closed this Nov 8, 2023
@marwen-abid marwen-abid deleted the merge-develop-mtn branch November 8, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants