[Hot-fix] Retry payment button was not showing up (#72) #74
+56
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What The retry payment button was not showing up after #15. The code was relying on the order of the entries in the status_history array. Status history is metadata, so it's not very reliable and we should rely on the status instead. ### How was it tested? 1. Pointed my FE to the dev instance (https://stellar-disbursement-platform-backend-dev.stellar.org) 2. Created a payment to my phone number 3. Registered a wallet using the demo wallet, but without creating the account 4. The payment failed with op_no_destination 5. I created the account and retried it 6. The payment failed with op_no_trust 7. I created the trustline and retried it 8. It succeeded 🎉 The payment used for this test is at https://stellar-disbursement-platform-frontend-dev.stellar.org/payments/b27db2ed-dd87-4127-b165-98f98c70144b
ceciliaromao
approved these changes
Feb 9, 2024
|
stellar-disbursement-platform-frontend-preview is available here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The retry payment button was not showing up after PR #15.
The code was relying on the order of the entries in the status_history array. Status history is metadata, so it's not very reliable and we should rely on the status instead.
How was it tested?
The payment used for this test is at https://stellar-disbursement-platform-frontend-dev.stellar.org/payments/b27db2ed-dd87-4127-b165-98f98c70144b