Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore - improve reset password hint #89

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

marwen-abid
Copy link
Collaborator

@marwen-abid marwen-abid commented Apr 3, 2024

What

Improve hint message from reset-password screen to list the special characters accepted in the password.
image

This came as a follow-up to this user error: https://stellarfoundation.slack.com/archives/C04C9MLM9UZ/p1712178109294219?thread_ts=1711755217.316099&cid=C04C9MLM9UZ

@marwen-abid marwen-abid self-assigned this Apr 3, 2024
@marwen-abid marwen-abid force-pushed the chore/improve-password-error-msg branch from e67e464 to 9f1533d Compare April 3, 2024 23:38
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr89.previews.kube001.services.stellar-ops.com/

@marwen-abid marwen-abid force-pushed the chore/improve-password-error-msg branch from 9f1533d to 005b429 Compare April 4, 2024 17:35
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr89.previews.kube001.services.stellar-ops.com/

@marwen-abid marwen-abid requested a review from quietbits April 4, 2024 17:44
@marwen-abid marwen-abid requested a review from ceciliaromao April 4, 2024 17:48
src/pages/ResetPassword.tsx Outdated Show resolved Hide resolved
@marwen-abid marwen-abid changed the title chore - improve password error message chore - improve reset password hint Apr 4, 2024
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr89.previews.kube001.services.stellar-ops.com/

Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marwen-abid marwen-abid merged commit 5f4fedc into develop Apr 4, 2024
5 checks passed
@marwen-abid marwen-abid deleted the chore/improve-password-error-msg branch April 4, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants