Skip to content

Commit

Permalink
CAP-51: Small tweaks (#1442)
Browse files Browse the repository at this point in the history
* CAP-51: Add client data JSON example

* CAP-51: Small tweaks
  • Loading branch information
leighmcculloch authored Feb 13, 2024
1 parent 6a0de99 commit 8571ed1
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions core/cap-0051.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,9 @@ Regarding base64 url encoding, it is possible to embed a small and efficient
fixed width base64 url encoder into a contract.

Regarding JSON, it has not been proven feasible to include a complete JSON
decoder or encoder, but given the JSON format, it is feasible to search the
client data JSON for the base64 url encoded challenge surrounded by `"`, and
then surrounded by either `:`, `,`, ` `, `{`, or `}`. Assuming consistency with
which clients produce the client data JSON it is also possible to check the
prefix of the client data JSON contains an exact format including the base64 url
encoded challenge. **(TODO: This paragraph is incorrect and needs replacing with
nother solution.)**
decoder or encoder, and as such implementing webauthn verification is also
dependent on the addition of a JSON host function interface that is out-of-scope
of this proposal.

## Protocol Upgrade Transition

Expand Down Expand Up @@ -231,7 +227,7 @@ reasons, such as resource cost or privacy.
### Audited Implementations

The only ECDSA secp256r1 pure-Rust crates that the Soroban environment could
embed are the [p256] and [ECDSA] crates. The two crates have never been
embed are the [p256] and [ecdsa] crates. The two crates have never been
independently audited.

## Test Cases
Expand All @@ -244,5 +240,5 @@ None yet. But will be tracked by [stellar/rs-sorovan-env#807] if implemented.

[Webauthn]: https://www.w3.org/TR/webauthn-2/
[p256]: https://crates.io/crates/p256
[ECDSA]: https://crates.io/crates/ECDSA
[ecdsa]: https://crates.io/crates/ecdsa
[stellar/rs-soroban-env#807]: https://github.com/stellar/rs-soroban-env/issues/807

0 comments on commit 8571ed1

Please sign in to comment.