[TS] Implement support for SEP-7 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @returns {boolen} returns `true` if it's a valid Sep-7 uri, `false` otherwise. | ||
| */ | ||
| export const isValidSep7Uri = (uri: string): boolean => { |
There was a problem hiding this comment.
Should this check that the xdr parameter for tx operations are a valid TransactionEnvelope?
Same question for destination on the pay operation, should it check that the value is a valid account ID?
There was a problem hiding this comment.
Good call, I like your suggestions :)
I think I'll make this function returning something like:
{
result: boolean;
reason: string;
}
Where reason should be a message letting devs know why the verification failed.
What do you think?
There was a problem hiding this comment.
yeah that sounds good to me, I like the more informational response. 👍
aristidesstaffieri
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://stellarorg.atlassian.net/jira/software/c/projects/WAL/boards/37?selectedIssue=WAL-1449
This PR adds support for SEP-7 through the following classes:
Sep7Base: abstract base class with common functions and attributes used by bothtxandpayoperationsSep7Tx: implements the Sep-7txoperationSep7Pay: implements the Sep-7payoperationThis PR also adds some convenient parsing/helper functions as follow:
isValidSep7Uri: checks if uri is Sep-7 compliant, if not returns a explanatoryreasonmessageparseSep7Uri: parses a Sep-7 uri to either a Sep7Tx or Sep7Pay instancesep7ReplacementsFromString: converts a complex replacements string to a list of friendly replacements objectssep7ReplacementsToString: converts a list of friendly replacements objects to a complex replacements stringThose classes and functions can be used to either
generatea new Sep-7 URI orhandlean existing Sep-7 URI.This PR also adds a bunch of
testsandJSDocsthat should cover all new classes and functions.This PR also adds a few missing types and exceptions from existing code (harmless changes).