Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize RPC health monitoring #104

Merged
merged 16 commits into from
Jan 15, 2025

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Jan 10, 2025

What

  • Currently, the code for tracking RPC health is duplicated across both the ingest server and the api server (when creating the channel accounts). This PR organises the RPC heartbeat tracking in a central location and simplifies its design.
  • Updated tests accordingly.

Why

The current solution for tracking rpc health was not a simple one and had some code duplication which are resolved in this PR.

Known limitations

NA

Issue that this PR addresses

Closes #105

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@aditya1702 aditya1702 force-pushed the rpc-health-monitoring branch from 98d6a39 to 3769556 Compare January 13, 2025 16:58
@aditya1702 aditya1702 changed the title [WIP] Centralize RPC health monitoring Centralize RPC health monitoring Jan 13, 2025
@aditya1702 aditya1702 marked this pull request as ready for review January 13, 2025 21:57
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, just one question about potentially adding a unit test

@aditya1702 aditya1702 merged commit 9a2358c into stellar:main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralise RPC health monitoring
2 participants