Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update readme, rename to stellar-rpc, make sentry optional #97

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

JakeUrban
Copy link
Contributor

What

This PR contains changes made to wallet-backend necessary to get my local environment setup as well as changes to the README to provide additional guidance to future contributors.

Why

I had some trouble following the README as-is, and there were a few bugs / minor improvements worth making rather than working around them.

Known limitations

N/A

Issue that this PR addresses

Partially addresses #95

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@JakeUrban JakeUrban assigned JakeUrban and unassigned JakeUrban Jan 2, 2025
Copy link
Contributor

@aditya1702 aditya1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeUrban JakeUrban merged commit f0d66c0 into main Jan 2, 2025
5 checks passed
@JakeUrban JakeUrban deleted the contributor-exp-improvements branch January 2, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants