-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sprocket to latest WDL crate #46
Draft
a-frantz
wants to merge
11
commits into
main
Choose a base branch
from
update-wdl-crates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b3dbcee
chore: update sprocket to latest WDL crate
a-frantz d0d5b0a
feat: --local-only and --single-document args to check
a-frantz 4ebabcd
Update CHANGELOG.md
a-frantz a35bf8b
Update CHANGELOG.md
a-frantz 6e1c196
chore: cargo update
a-frantz c1cbd2b
chore: fmt
a-frantz cab0c02
feat: add shellcheck
a-frantz b061ef1
docs: label shellcheck experimental
a-frantz 2b81661
Update Cargo.lock
a-frantz d2d7353
chore: update to latest
a-frantz faf1dbf
chore: clippy and dmt
a-frantz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't Clay want to keep
sprocket
pinned to a release?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that release doesn't exist yet. This PR will be updated to pull an official release once one exists.
I think the language here is fine? Maybe it should specify the version of "latest" once that is out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I would swap
latest
with the version when it is known.