Add aarch64 as alias for arm64 architecture #1441
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
When running in a dev-container on Mac Silicon, e.g. in a bookworm image,
Running
uname -m
on host yields arm64.Simple
devcontainer.json
to reproduce:Opening a terminal in the dev-container and running
uname -m
yieldsaarch64
.Running the install.sh script (via
bash
notsh
and referencing v3.2.2.3 since current stable/default v3.1.0.2 has no release onarm64-linux
):version=v3.2.2.3 bash -c "$(curl -fsSL https://raw.githubusercontent.com/streamnative/pulsarctl/master/install.sh)"
Yields:
This is due to script trying to download https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-aarch64-linux.tar.gz which should be https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-arm64-linux.tar.gz.
Modifications
Added
aarch64
as alias forarm64
architecture ininstall.sh
.Verifying this change
This change required Apple Silicon processor to test, but regression is covered by existing tests.
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
A bug
doc
(If this PR contains doc changes)