Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 as alias for arm64 architecture #1441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veggerby
Copy link

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

When running in a dev-container on Mac Silicon, e.g. in a bookworm image,

Running uname -m on host yields arm64.

Simple devcontainer.json to reproduce:

{
    "name": "PulsarCTL",
    "image": "mcr.microsoft.com/devcontainers/base:bookworm"
}

Opening a terminal in the dev-container and running uname -m yields aarch64.

Running the install.sh script (via bash not sh and referencing v3.2.2.3 since current stable/default v3.1.0.2 has no release on arm64-linux):

version=v3.2.2.3 bash -c "$(curl -fsSL https://raw.githubusercontent.com/streamnative/pulsarctl/master/install.sh)"

Yields:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     42      0 --:--:-- --:--:-- --:--:--    42

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

This is due to script trying to download https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-aarch64-linux.tar.gz which should be https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-arm64-linux.tar.gz.

Modifications

Added aarch64 as alias for arm64 architecture in install.sh.

Verifying this change

  • Make sure that the change passes the CI checks.

This change required Apple Silicon processor to test, but regression is covered by existing tests.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    A bug

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants