add recipients component to connect-js #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
requested changes
Oct 8, 2024
types/config.ts
Outdated
| @@ -147,6 +147,9 @@ export const ConnectElementCustomMethodConfig = { | |||
| "financial-account-transactions": { | |||
| setFinancialAccount: (_financialAccount: string): void => {} | |||
| }, | |||
| recipients: { | |||
| setDataSource: (_dataSource: string): void => {} | |||
There was a problem hiding this comment.
Can we make this a strong type?
There was a problem hiding this comment.
And also export this type, similar to other exported types in this file (so it can be reused in the react SDK)
kostas-stripe
requested review from
jorgea-stripe and
jojo-stripe
and removed request for
hliana-stripe
jojo-stripe
approved these changes
Oct 8, 2024
kostas-stripe
requested review from
jorgea-stripe
and removed request for
jorgea-stripe
jorgea-stripe
approved these changes
Oct 8, 2024
jorgea-stripe
added a commit
that referenced
this pull request
Oct 9, 2024
This reverts commit a960402.
jorgea-stripe
added a commit
that referenced
this pull request
Oct 9, 2024
kostas-stripe
added a commit
that referenced
this pull request
Oct 9, 2024
kostas-stripe
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new recipients component to connect-js