馃惓 Add EXPOSE statement to Dockerfile - #1222
Merged
Merged
Conversation
Also makes the default port environment variable configurable using the same build arg for consistency.
threkk
marked this pull request as ready for review
June 11, 2026 23:28
aaronleopold
changed the title
EXPOSE statement to Dockerfile
aaronleopold
pushed a commit
that referenced
this pull request
Jun 12, 2026
Collaborator
|
Note for posterity: I did not catch that this was based into main. I cherry picked to |
Contributor
Author
|
Thanks for the merge! That was my mistake, I didn't know against which branch I should have opened the PR :( |
Collaborator
|
No worries at all, no harm done! I caught it, just not until afterwards |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the default port, configurable using a build argument. It also uses the same argument to configure the environment port for consistency. Closes #1221