feat: express TPC-H plan generation with existing infra #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
tpch-plan-generation
branch
from
552f27d to
d4c2804
Compare
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
tpch-plan-generation
branch
from
d4c2804 to
ebfe206
Compare
EpsilonPrime
approved these changes
Dec 17, 2024
This PR uses `substrait_producer_sql_test` from `common.py` to express the TPC-H test targets that regenerate the Substrait plans using Isthmus. This replaces test-specific code with generic code and is, thus, a steps towards reducing the complexity of the tests. As a consequence, the paths of some snapshots change; however, note in the corresponding git commit that all files are renamed without content changes. Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
tpch-plan-generation
branch
from
ebfe206 to
d03e0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on and, therefor, includes #171.This PR uses
substrait_producer_sql_testfromcommon.pyto express the TPC-H test targets that regenerate the Substrait plans using Isthmus. This replaces test-specific code with generic code and is, thus, a steps towards reducing the complexity of the tests. As a consequence, the paths of some snapshots change; however, note in the corresponding git commit that all files are renamed without content changes.