Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #625 #628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #625 #628

wants to merge 1 commit into from
+73 −15

Conversation

anya-xcode
Copy link

@anya-xcode anya-xcode commented Dec 31, 2024 •
edited
Loading

Fixes #625

Description

Introducing design enhancements to the NewsShelter section, focusing on the email input field and the subscribe button. The aim is to deliver a more polished, user-friendly interface that aligns with modern design practices and improves the overall user experience.

Improvements Implemented

  1. Email Input Field:

    • Introduced a rounded border for a softer and more appealing look.
    • Added a subtle glow effect on focus to enhance interactivity and draw user attention.
    • Included the required attribute for better form validation.

  2. Subscribe Button:

    • Applied a hover effect with a smooth color transition to provide visual feedback.
    • Adjusted padding for better alignment and visual harmony with the input field.

  3. Scoped Styles:

    • All new styles are scoped locally using <style> tags within the file to avoid affecting global styles.

Impact

  • Enhanced User Experience:

    These updates create a visually appealing and interactive interface, encouraging user engagement.

  • Improved Accessibility:

    The refined designs ensure usability across various screen sizes, enhancing responsiveness.

  • Better Maintainability:

    Scoped styles make the design changes easier to manage without interfering with global CSS.

Screenshots

Before

Screenshot: Before

After

Screenshot: After

@anya-xcode anya-xcode mentioned this pull request Dec 31, 2024
Open
quozl
quozl requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@quozl quozl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode/settings.json Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
anya-xcode added a commit to anya-xcode/www that referenced this pull request Jan 1, 2025
@anya-xcode
added Email rounded corner and subscribe button hover effect sugarlab…
23fa694 
…s#625 comment fix sugarlabs#628
@anya-xcode
Copy link
Author

@quozl please review changes done

@quozl
Copy link
Contributor

quozl commented Jan 3, 2025

Good progress. Still commit messages do not follow our guidance. Link was given above.

Suggest you squash the commits and reword using git rebase -i and then git push --force.

@anya-xcode anya-xcode changed the title added Email rounded corner and subscribe button hover effect #625 done Fixes #625 Jan 6, 2025
@anya-xcode
Copy link
Author

@quozl
Please review changes in commit message is done!

@quozl
Copy link
Contributor

quozl commented Jan 6, 2025

Thanks. Does not comply. Perhaps you haven't pushed the changes?

Please check what I've checked;

Guidance for review: https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#guide-for-reviewers

Guidance for commit message: https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits

@anya-xcode
Copy link
Author

@quozl
please review changes done!

@quozl
Copy link
Contributor

quozl commented Jan 7, 2025

Thanks.

  • line 107, the type of input is set to " email" instead of "email", i.e. a space before email, why is that?
  • your commit message complies but is very bare of information, yet it is clear that you have plenty to say in your pull request introduction comment; isn't there anything in the latter that you could add?

Remember that GitHub pull request does not get kept in the git history, and it is the git history we want to ensure remains useful for everyone who reads it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quozl quozl quozl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance CSS Styling for NewsShelter Section
2 participants
@anya-xcode @quozl