-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #625 #628
base: master
Are you sure you want to change the base?
Fixes #625 #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- improve the commit message, see our guidance.
@quozl please review changes done |
Good progress. Still commit messages do not follow our guidance. Link was given above. Suggest you squash the commits and reword using |
23fa694
to
4e667d7
Compare
@quozl |
Thanks. Does not comply. Perhaps you haven't pushed the changes? Please check what I've checked;
Guidance for review: https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#guide-for-reviewers Guidance for commit message: https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits |
4e667d7
to
f65c15e
Compare
@quozl |
Thanks.
Remember that GitHub pull request does not get kept in the git history, and it is the git history we want to ensure remains useful for everyone who reads it. |
Fixes #625
Description
Introducing design enhancements to the NewsShelter section, focusing on the email input field and the subscribe button. The aim is to deliver a more polished, user-friendly interface that aligns with modern design practices and improves the overall user experience.
Improvements Implemented
Email Input Field:
Subscribe Button:
Scoped Styles:
<style>
tags within the file to avoid affecting global styles.Impact
Enhanced User Experience:
These updates create a visually appealing and interactive interface, encouraging user engagement.Improved Accessibility:
The refined designs ensure usability across various screen sizes, enhancing responsiveness.Better Maintainability:
Scoped styles make the design changes easier to manage without interfering with global CSS.Screenshots
Before
After