Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openseadragon to 2.2.1 #786

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Update openseadragon to 2.2.1 #786

merged 1 commit into from
Jul 13, 2017

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jul 13, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.158% when pulling 8a53ee8 on update_openseadragon into bc22dc3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.158% when pulling 8a53ee8 on update_openseadragon into bc22dc3 on master.

@mejackreed
Copy link
Contributor

I think we want to kill the map.js file as it has caused us some problems in the past. #336

Though not quite sure if that problem would have been resolved.

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 13, 2017

@mejackreed I didn't see any problems with it on my box. Do you see any? Do you know what the nature of the problem was?

@mejackreed
Copy link
Contributor

I'm getting an error in the log:

http://localhost:3000/iframe?url=https://purl.stanford.edu/fw090jw3474&min_files_to_search=10 -> /assets/image_x-0392e4e42e8ebc34756824658ef583bf15d5da5bd50993971e080a080f73529c.js?_=1499970720870
Started GET "/pages/openseadragon.min.js.map" for 127.0.0.1 at 2017-07-13 14:32:00 -0400
Processing by PagesController#show as HTML
  Parameters: {"id"=>"openseadragon.min.js.map"}
Completed 404 Not Found in 8ms



ActionController::RoutingError (No such page: openseadragon.min.js.map):

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 13, 2017

Okay, as far as I can tell, this only occurs when you are in Chrome and have the developer console open when you load the page. Does that sound right?

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 13, 2017

Here's an issue to track: rharriso/bower-rails#213

@jcoyne
Copy link
Contributor Author

jcoyne commented Jul 13, 2017

@mejackreed as far as I can tell, removing the map file does not make the problem go away.

@mejackreed
Copy link
Contributor

Ah thanks for catching that. We had previously also removed the reference from the openseadragon.min.js file too.

@mejackreed mejackreed merged commit a8a5255 into master Jul 13, 2017
@mejackreed mejackreed deleted the update_openseadragon branch July 13, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants