Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support encrypted values in config #3013

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 3, 2025

What kind of change does this PR introduce?

feature

What is the new behavior?

Follow dotenvx convention for encrypted secrets.

api_key = "encrypted:<base64_encoded>"

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 3, 2025 12:24
@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12703005375

Details

  • 116 of 258 (44.96%) changed or added relevant lines in 6 files are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 58.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/config/push/push.go 0 2 0.0%
pkg/config/config.go 26 34 76.47%
internal/start/start.go 1 12 8.33%
pkg/config/auth.go 40 161 24.84%
Files with Coverage Reduction New Missed Lines %
pkg/config/config.go 1 53.96%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
pkg/config/auth.go 6 58.85%
Totals Coverage Status
Change from base Build 12687685954: -0.2%
Covered Lines: 7616
Relevant Lines: 12993

💛 - Coveralls

@sweatybridge sweatybridge force-pushed the encrypt-secret branch 2 times, most recently from 88829c5 to aa1eb3c Compare January 8, 2025 05:42
@sweatybridge sweatybridge enabled auto-merge (squash) January 10, 2025 03:57
@sweatybridge sweatybridge merged commit ce47b34 into develop Jan 10, 2025
8 checks passed
@sweatybridge sweatybridge deleted the encrypt-secret branch January 10, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants