Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update envoy lds with origin protection keys #1403

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hf
Copy link
Contributor

@hf hf commented Jan 9, 2025

Updates the lds.supabase.yaml file to include origin protection keys by default. The string supabase_origin_protection_key is replaced with the exact OPK during project initialization.

See also:

@hf hf requested a review from a team as a code owner January 9, 2025 10:58
@hf
Copy link
Contributor Author

hf commented Jan 9, 2025

This change should go out to all Postgres versions that can be selected by customers. How do I do that?

Comment on lines +98 to +99
or_ids:
ids:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not doing a direct comparison here rather than an array check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants