Put new keycodes at the end to avoid breaking keymaps; add comments

svalboard · Jun 23, 2024 · 2130669 · 2130669
1 parent a59d0c6
commit 2130669
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/keyboards/svalboard/keymaps/keymap_support.h b/keyboards/svalboard/keymaps/keymap_support.h
@@ -28,8 +28,6 @@ enum my_keycodes {
     SV_RIGHT_DPI_DEC,
     SV_LEFT_SCROLL_TOGGLE,
     SV_RIGHT_SCROLL_TOGGLE,
-    SV_LEFT_SCROLL_HOLD,
-    SV_RIGHT_SCROLL_HOLD,
     SV_RECALIBRATE_POINTER,
     SV_MH_CHANGE_TIMEOUTS,
     SV_CAPS_WORD,
@@ -39,6 +37,9 @@ enum my_keycodes {
     SV_SNIPER_2,
     SV_SNIPER_3,
     SV_SNIPER_5,
+    SV_LEFT_SCROLL_HOLD,
+    SV_RIGHT_SCROLL_HOLD,
+    // New keycodes should go here, to avoid breaking existing keymaps - order must match vial.json
     KC_NORMAL_HOLD = SAFE_RANGE,
     KC_FUNC_HOLD,
     SV_SAFE_RANGE, // Keycodes over this are safe on Svalboard.

diff --git a/keyboards/svalboard/keymaps/vial/vial.json b/keyboards/svalboard/keymaps/vial/vial.json
@@ -36,16 +36,6 @@
         "title": "Toggle if the right pointer is scroll or pointer.",
         "name": "SV_RIGHT_SCROLL_TOGGLE"
       },
-      {
-        "shortName": "Scroll\nLeft\nHold",
-        "title": "Hold to make the left pointing device scroll",
-        "name": "SV_LEFT_SCROLL_HOLD"
-      },
-      {
-        "shortName": "Scroll\nRight\nHold",
-        "title": "Hold to make the right pointing device scroll",
-        "name": "SV_RIGHT_SCROLL_HOLD"
-      },
       {
         "shortName": "Fix\nDrift",
         "title": "Reset the calibration of the pointing device",
@@ -90,7 +80,18 @@
         "shortName": "Sniper\n5x",
         "title": "Slow the cursor 5x more.",
         "name": "SV_SNIPER_5"
+      },
+      {
+        "shortName": "Scroll\nLeft\nHold",
+        "title": "Hold to make the left pointing device scroll",
+        "name": "SV_LEFT_SCROLL_HOLD"
+      },
+      {
+        "shortName": "Scroll\nRight\nHold",
+        "title": "Hold to make the right pointing device scroll",
+        "name": "SV_RIGHT_SCROLL_HOLD"
       }
+      // New keycodes should go here, to avoid breaking existing keymaps - order must match keymap_support.h
     ],
     "layouts": {
       "keymap": [