Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Svalboard-specific firmware features documentation #56

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

vnegnev
Copy link

@vnegnev vnegnev commented Jun 22, 2024

Added a Markdown page in a docs folder, with a few screenshots. Most sections are currently empty, this is just establishing a place to add feature documentation later.

As new Svalboard-specific firmware features are added, it will be helpful to future users if the firmware developers add some feature documentation to this page (or new pages could be created and linked to).

In principle the contents of the docs folder could later be shifted to a GitHub wiki or similar, however this is far in the future and doesn't offer any advantages yet.

Copy link
Collaborator

@ilc ilc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in-line,

keyboards/svalboard/docs/automouse_allowed_keys.png Outdated Show resolved Hide resolved
keyboards/svalboard/readme.md Outdated Show resolved Hide resolved
@vnegnev
Copy link
Author

vnegnev commented Jun 23, 2024

I've made the requested changes and rebased off the latest vial commit.

@vnegnev vnegnev requested a review from ilc June 23, 2024 22:01
@ilc
Copy link
Collaborator

ilc commented Jun 23, 2024

LGTM.

@ilc ilc requested a review from morganvenable June 23, 2024 22:40
@morganvenable
Copy link

Lgtm

Copy link

@morganvenable morganvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Collaborator

@ilc ilc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ilc ilc merged commit f2ad4ce into svalboard:vial Jun 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants