Cleanup keymap_support.c
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like Achordion shouldn't be dependent on pointing devices anyways.
This moves all non-hold keys to activate on key-down, so we only need to think about clearing held states in the key-up case. It also aborts further handling of these keycodes once we're done with them. This fixes the issue with caps word toggle not actually toggling and getting processed multiple times. It does prevent users from hooking these custom keys, but if people know how to do that, they can probably figure out how to make their own custom key that calls the same code.
This is already defined in `trackpoint/config.h`. If you have input @ilc I'm all ears.
SiriusStarr
force-pushed
the
cleanup-keymap-support
branch
from
684efef to
3fff0f2
Compare
Merged
ilc
requested changes
Aug 2, 2024
ilc
approved these changes
Aug 3, 2024
|
LGTM - Running on the board I am using right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this is formatting-related. Do we have a standard formatter to run? And if not, should we?
If the automouse flags are just going to always be set, then we should probably remove all the (non-console/debug) ifdefs? My concern is ending up with some odd combination of flags such that things don't compile because we're accessing something not being defined or whatnot.
Anyways, this all builds and works fine for me, but more eyes on it would be good, obviously.