Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gen 2 Thumbs DD and also Fix removed thumb keys on boot. #70

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

ilc
Copy link
Collaborator

@ilc ilc commented Aug 29, 2024

Title says it.

ilc added 2 commits August 27, 2024 22:43
For reasons not well understood, the first matrix scan
comes out reversed.  QMK is not handling this well, so we just
set the first scan to 0, and move on.
Because Gen 2s can have inverted DD on their thumbs
we auto detect this instead of the entire thumb.
@ilc ilc requested a review from morganvenable August 29, 2024 04:54
Copy link

@morganvenable morganvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@ilc ilc merged commit 4ae8020 into svalboard:vial Aug 29, 2024
10 checks passed
@ilc ilc deleted the blank-and-thumb-fix branch August 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants