Explicitly use value type in apply

swift-nav · Mar 28, 2020 · 978fcf7 · 978fcf7
1 parent 8ec8b0d
commit 978fcf7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/include/albatross/src/indexing/async_apply.hpp b/include/albatross/src/indexing/async_apply.hpp
@@ -34,7 +34,7 @@ template <typename ValueType, typename ApplyFunction,
                                   int>::type = 0>
 inline void async_apply(const std::vector<ValueType> &xs, ApplyFunction &&f) {
   std::vector<std::future<void>> futures;
-  for (const auto &x : xs) {
+  for (const ValueType &x : xs) {
     futures.emplace_back(async_safe(f, x));
   }
   for (auto &f : futures) {
@@ -51,7 +51,7 @@ template <typename ValueType, typename ApplyFunction,
                                   int>::type = 0>
 inline auto async_apply(const std::vector<ValueType> &xs, ApplyFunction &&f) {
   std::vector<std::future<ApplyType>> futures;
-  for (const auto &x : xs) {
+  for (const ValueType &x : xs) {
     futures.emplace_back(async_safe(f, x));
   }
 

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_executable(albatross_unit_tests 
   test_apply.cc
-  test_async_utils.cc
+  test_async_apply.cc
   test_block_utils.cc
   test_call_trace.cc
   test_callers.cc

diff --git a/tests/test_async_utils.cc → tests/test_async_apply.cc b/tests/test_async_utils.cc → tests/test_async_apply.cc
@@ -13,7 +13,6 @@
 #include <gtest/gtest.h>
 
 #include <albatross/Indexing>
-#include <albatross/utils/AsyncUtils>
 #include <albatross/utils/RandomUtils>
 
 #include <chrono>