Bump braces, webpack and webpack-cli #1458
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependencies [braces](https://github.com/micromatch/braces), [webpack](https://github.com/webpack/webpack) and [webpack-cli](https://github.com/webpack/webpack-cli). These dependencies need to be updated together. Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `webpack` from 4.26.1 to 5.96.1 - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.26.1...v5.96.1) Updates `webpack-cli` from 3.3.12 to 5.1.4 - [Release notes](https://github.com/webpack/webpack-cli/releases) - [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-cli/compare/[email protected]) --- updated-dependencies: - dependency-name: braces dependency-type: indirect - dependency-name: webpack dependency-type: direct:development - dependency-name: webpack-cli dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Note I have introduced a change that prevents Sonarcloud actions from failing when running on PRs created by @dependabot .
To understand the impact of the changes and make a decision if we want to merge that. |
I think I understand the difference (we work around read-only permissions granted to PRs opened by dependabot), but why wasn't it an issue before this PR? I'm struggling to assess the risk here: would the vulnerability be if, for example, someone breaks in sonarcloud and tries to steal secrets through it? 🤔 |
From what I can see, the PRs that I merged in the last days were rebased by me manually, making me the author of the commits. If dependabot is not the author, the secrets work as intended.
I think the attack vector is something like: |
|
Alternative solution: |
There was a problem hiding this comment.
Hi @sbmueller I don't think we can take this change. This is a public repo where we allow anyone as well as dependabot to open PRs against. This is the definition of allowing untrusted PRs. On top of that, the things you shared said:
TL;DR: Combining pull_request_target workflow trigger with an explicit checkout of an untrusted PR is a dangerous practice that may lead to repository compromise.
To my eye, we are doing that, every job has actions/checkout@v4, we're not even gating it to PRs authored by dependabot. I don't understand how we are mitigating against this risk
I appreciate you highlighting why this change may be dangerous, but from my read of the docs, I would advise against taking this change.
sbmueller
force-pushed
the
dependabot/npm_and_yarn/multi-d851bdffc3
branch
from
cf4031c to
63d0fed
Compare
|
|
@pcrumley I agree, removed the change and implemented skipping the job if the actor is @dependabot . |
sbmueller
dismissed
pcrumley’s stale review
Suggested changes implemented, merging now.
Bumps braces to 3.0.3 and updates ancestor dependencies braces, webpack and webpack-cli. These dependencies need to be updated together.
Updates
bracesfrom 3.0.2 to 3.0.3Commits
74b2db23.0.388f1429update eslint. lint, fix unit tests.415d660Snyk js braces 6838727 (#40)190510ffix tests, skip 1 test in test/braces.expand716eb9freadme bumpa5851e5Merge pull request #37 from coderaiser/fix/vulnerability2092bd1feature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...9f5b4cffix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)98414f9remove funding file665ab5dupdate keepEscaping doc (#27)Updates
webpackfrom 4.26.1 to 5.96.1Release notes
Sourced from webpack's releases.
... (truncated)
Commits
d4ced73chore(release): 5.96.17d6dbeafix: types regression in validate5c556e3fix: types regression in validate2420eaefix: add@types/eslint-scopeto dependencies due types regressionec45d2dfix: add@types/eslint-scopeto dependenciesaff0c3echore(release): 5.96.06f11ec1refactor: module source types codeb07142frefactor: module source types code7d98b3cfix: Module Federation should track all referenced chunks6d09769chore: lintingMaintainer changes
This version was pushed to npm by evilebottnawi, a new releaser for webpack since your current version.
Updates
webpack-clifrom 3.3.12 to 5.1.4Release notes
Sourced from webpack-cli's releases.
... (truncated)
Changelog
Sourced from webpack-cli's changelog.
... (truncated)
Commits
e07f0e5chore(release): publish new version0345c6fchore(deps-dev): bump@typescript-eslint/parserfrom 5.59.8 to 5.59.9 (#3839)f659624fix: multi compiler progress output0d1ff01chore(deps-dev): bump webpack from 5.85.0 to 5.85.1 (#3837)a7ec146chore(deps-dev): bump@typescript-eslint/eslint-plugin(#3838)9464635chore(deps-dev): bump eslint from 8.41.0 to 8.42.0 (#3835)cf1796fdocs: update changelog7899c39chore(release): publish new versionbb4f8ebfix: regression for custom configurations (#3834)14b9c18docs: update changelogDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.