Repository navigation
Fix content parameter docs for regex replacing APIs - #916
Open
sarthakkaushik927 wants to merge 1 commit into
Open
sarthakkaushik927 wants to merge 1 commit into
sarthakkaushik927 wants to merge 1 commit into
Conversation
The RegexBuilder replacing(...) and replace(...) overloads described their `content` parameter as "A closure that returns the collection to search for and replace", but the closure builds a regex. Say "regex" instead. Resolves swiftlang/swift#74008 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RegexBuilder
replacing(...)andreplace(...)overloads that take a regex-builder closure described theircontentparameter as:The closure returns a regex, not a collection. This changes the six occurrences in
Sources/RegexBuilder/Algorithms.swiftto "A closure that returns the regex to search for and replace", matching the wording the other RegexBuilder algorithms in the same file already use.Documentation only; no code changes.
Resolves swiftlang/swift#74008