Fix two bugs which cause SIL verification errors #78524
Open
+83
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dundant phi argument Fixes a verifier crash
So far we only checked the ownership of incoming values. But even if the incoming instruction has no ownership, the argument may have. This can happen with enums which are constructed with a non-payload case: %1 = enum $Optional<C>, #Optional.none!enumelt br bb3(%1) bb1(%3 : @owned $Optional<C>): Fixes an ownership verification error: rdar://142506300
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we only checked the ownership of incoming values.
But even if the incoming instruction has no ownership, the argument may have.
This can happen with enums which are constructed with a non-payload case:
We need to make sure that the arguments to a borrowed-from instruction are not borrowed-from instructions, too, but their underlying phi arguments.
rdar://142506300