[6.1][Sema] Look through ActorIsolationErasureExpr when finding function…
#78536
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DeclRefs for `rethrows` checking. This conversion has no effect on `rethrows` checking and should be ignored. Resolves: rdar://142562250 (cherry picked from commit e0bfa13)
|
@swift-ci please test |
hborla
approved these changes
Jan 10, 2025
|
@swift-ci please clean test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… DeclRefs for
rethrowschecking.Cherry-pick of #78535
Explanation:
Fixes a source compatibility regression when actor isolated function values are passed to throwing parameters.
This conversion has no effect on
rethrowschecking and should be ignored.Main Branch PR: [Sema] Look through
ActorIsolationErasureExprwhen finding function… #78535Resolves: rdar://142562250
Risk: Very Low (this conversion appears in a limit set of circumstances and has no effect on
rethrowschecking).Reviewed By: @hborla
Testing: Added new tests to the Concurrency test suite.
(cherry picked from commit e0bfa13)