Repository navigation
fix(build): create output parent directory before native link - #157
Merged
matyhtf merged 1 commit intoOct 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed failure
When the configured output path lives inside a directory that does not exist yet, the build compiles every source (minutes on a real project) and only then dies with a bare linker error:
The compiler could not have produced the artifact regardless of how long it compiled: the linker never creates parent directories, and nothing before the link creates them either.
Root cause
NativeBuilder::link()(src/Build/NativeBuilder.php) execs the link command without ensuring the target's parent directory exists. The Nano path is asymmetric evidence that this is an omission rather than a design choice:NativeSourceProjectBuilderalready callsensureDirectory(dirname($project->output))right before linking (src/Build/NativeSourceProjectBuilder.php), but the plaintpc.php file.php -o .../project.ymlpath has no equivalent.Fix
NativeBuilder::link()now ensures the output parent directory exists (recursively) before invoking the linker, following the sameensureDirectory()pattern already used on the Nano path and inAtomicFile,EmbeddedArchiveBuilderandEmbeddedOpcodeGenerator:Translator::linkNativeTarget()converts the exception into the regular CLI fatal error, so a misconfigured output path now fails withCannot create output directory: ...instead of a raw ld message.Both entry points go through the same link call, so
output:inproject.ymland the-oCLI flag are covered, as is theembedSAPI target (which links throughlinkNativeTarget()as well).