Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix do not track nested reactivity in map_keyed/map_indexed #742

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

lukechu10
Copy link
Member

Fixes #739 but not #741

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (7e58231) to head (4e924b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/sycamore-reactive/src/utils.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
+ Coverage   72.65%   72.92%   +0.26%     
==========================================
  Files          44       44              
  Lines        6378     6400      +22     
==========================================
+ Hits         4634     4667      +33     
+ Misses       1744     1733      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 merged commit 217ee7c into sycamore-rs:main Oct 29, 2024
12 checks passed
@lukechu10 lukechu10 deleted the fix-issue-739 branch November 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'invalid SlotMap key used' when removing an item with nested reactivity from a list that has cleanup
1 participant