Keep the 'is' prefix on a boolean property when making the setter

symfony · Dec 7, 2024 · 9fa9221 · 9fa9221
1 parent ce60831
commit 9fa9221
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/src/Util/ClassSourceManipulator.php b/src/Util/ClassSourceManipulator.php
@@ -485,10 +485,6 @@ private function createSetterNodeBuilder(string $propertyName, $type, bool $isNu
 
     private function getSetterName(string $propertyName, $type): string
     {
-        if ('bool' === $type && 0 === strncasecmp($propertyName, 'is', 2)) {
-            return 'set'.Str::asCamelCase(substr($propertyName, 2));
-        }
-
         return 'set'.Str::asCamelCase($propertyName);
     }
 

diff --git a/templates/verifyEmail/EmailVerifier.tpl.php b/templates/verifyEmail/EmailVerifier.tpl.php
@@ -43,7 +43,7 @@ public function handleEmailConfirmation(Request $request, <?= $user_class_name ?
     {
         $this->verifyEmailHelper->validateEmailConfirmationFromRequest($request, (string) $user-><?= $id_getter ?>(), (string) $user-><?= $email_getter?>());
 
-        $user->setVerified(true);
+        $user->setIsVerified(true);
 
         $this->entityManager->persist($user);
         $this->entityManager->flush();

diff --git a/tests/Util/fixtures/add_setter/User_bool_begins_with_is.php b/tests/Util/fixtures/add_setter/User_bool_begins_with_is.php
@@ -17,7 +17,7 @@ public function getId(): ?int
         return $this->id;
     }
 
-    public function setFooProp(bool $isFooProp): static
+    public function setIsFooProp(bool $isFooProp): static
     {
         $this->isFooProp = $isFooProp;